Skip to content

Conversation

@Happypig375
Copy link
Member

No description provided.

@Happypig375
Copy link
Member Author

@copilot Try to fix the CPP build error

Copy link
Contributor

Copilot AI commented Jan 1, 2026

@Happypig375 I've opened a new pull request, #641, to work on those changes. Once the pull request is ready, I'll request review from you.

@Happypig375
Copy link
Member Author

@copilot It seems that AngouriMath.CPP.Exporting isn't generating native binaries to be copied over to AngouriMath.CPP.Importing in the CI. What happened?

Copy link
Contributor

Copilot AI commented Jan 1, 2026

@Happypig375 I've opened a new pull request, #642, to work on those changes. Once the pull request is ready, I'll request review from you.

@Happypig375
Copy link
Member Author

@WhiteBlackGoose Why are some of these projects not in the solution?

@WhiteBlackGoose
Copy link
Member

The C++ projects aren't really worth maintaining IMO, I don't think anybody uses those unironically.

If some .net projects aren't in the solution, it's probably unintentional. At some point I stopped using VS so I didn't need the solution file any more. Feel free to add them

@WhiteBlackGoose
Copy link
Member

Also I recommend using squash and merge so you get one commit per PR instead of keeping all temporary commits in main

@Happypig375
Copy link
Member Author

I have no idea how including more projects in the solution fixes C++ Test CI but sure I guess

@Happypig375 Happypig375 merged commit d04f657 into master Jan 2, 2026
28 checks passed
@Happypig375 Happypig375 deleted the ci-fix branch January 2, 2026 13:09
@Happypig375 Happypig375 mentioned this pull request Jan 2, 2026
@Happypig375
Copy link
Member Author

@WhiteBlackGoose push another preview to nuget please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants